Expand Scan Areas List #516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Normalize manual areas - Add parents property support - Fix instanceof error
- Respect geojson fill and stroke colors - Consolidate some of the logic into initial config instead of in resolvers - Change the spacing on WithSubItems for better locale support
- Move parent finding logic to the server for simplicity - Add a GQL endpoint and all other relevant code needed for that - Add a configurable height value for the menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using with an areas.json file, just add the parent name to the properties of the child feature/area, next to the name, etc.
When using manualAreas in the config, just add a parent property at the same level as the name/lat/lon/zoom.
You do not need an area/feature with the same parent name if you don't want it to be clickable.