Added a grass icon for Pokemon found in nearby cells #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TurtIeSocks
reviewed
Aug 9, 2022
Collaborator
TurtIeSocks
left a comment
TurtIeSocks
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Logic seems fine, I want to think on this a little bit though to think if there's an alternative before committing to making cell mons use the "fancyMarker", since it's a little bit slower and Pokemon rendering is already on the slower side.
Contributor
Author
|
Sure! I thought about that too, but figured that usually you don't have that many cell mons passing the filters that it'd make that big a difference. Or at least I don't 😃 |
TurtIeSocks
approved these changes
Aug 12, 2022
Collaborator
|
Eh after testing, performance seems fine. Thanks for the cool PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A marker for for mons found in nearby cells so users can see right away that their location isn't accurate.
I didn't quite understand the current calculation for icon placement when accounting for the pokemon icon offsetX so I just set the position to fixed 10%.