Fix mislabeled environment variables #567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync Develop with Main
`SCANNER_DB_USER` and `MANUAL_DB_USER` were mislabeled and do not match the consts in [/server/src/services/config.js](https://github.com/WatWowMap/ReactMap/blob/254c96a29238ce6b14a42d9d630139dcd2fab22f/server/src/services/config.js#L17) This commit changes the mentioned environment variables to be `SCANNER_DB_USERNAME` and `MANUAL_DB_USERNAME` respectively.
TurtIeSocks
requested changes
Sep 13, 2022
Collaborator
TurtIeSocks
left a comment
TurtIeSocks
left a comment
There was a problem hiding this comment.
Oops. It amazes me that no one has noticed these things up until now 😅 PR itself looks good but can you change the target to the develop branch?
Contributor
Author
Somehow I manage to find the things that don't cause anyone else issues. lol Target has been updated. |
TurtIeSocks
approved these changes
Sep 13, 2022
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCANNER_DB_USERandMANUAL_DB_USERwere mislabeled and do not match the consts in /server/src/services/config.jsThis commit changes the mentioned environment variables to be
SCANNER_DB_USERNAMEandMANUAL_DB_USERNAMErespectively.