Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions public/base-locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -558,5 +558,7 @@
"seen_nearby_cell": "Seen in this Cell",
"seen_lure_encounter": "Lure Encounter",
"seen_lure_wild": "Lure Spawn",
"seen_wild": "Wild Spawn"
}
"seen_wild": "Wild Spawn",
"event_stops": "Event Stops",
"event_stop_timers": "Event Stop Timers"
}
2 changes: 2 additions & 0 deletions server/src/configs/default.json
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,7 @@
"clustering": true,
"invasionTimers": false,
"lureTimers": false,
"eventStopTimers": false,
"interactionRanges": false,
"lureRange": false,
"madQuestText": false,
Expand Down Expand Up @@ -419,6 +420,7 @@
"levels": "all",
"lures": true,
"quests": true,
"eventStops": false,
"questSet": "both",
"items": true,
"megaEnergy": true,
Expand Down
49 changes: 42 additions & 7 deletions server/src/models/Pokestop.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ module.exports = class Pokestop extends Model {
onlyInvasions,
onlyArEligible,
onlyAllPokestops,
onlyEventStops,
onlyAreas = [],
},
ts,
Expand Down Expand Up @@ -515,11 +516,24 @@ module.exports = class Pokestop extends Model {
ar.where(isMad ? 'is_ar_scan_eligible' : 'ar_scan_eligible', 1)
})
}
if (onlyEventStops && pokestopPerms) {
stops.orWhere((event) => {
event
.where('display_type', 7)
.andWhere('character', 0)
.andWhere(
multiInvasionMs ? 'expiration_ms' : 'expiration',
'>=',
safeTs * (multiInvasionMs ? 1000 : 1),
)
})
}
})
} else if (onlyLevels !== 'all' && hasPowerUp) {
query.andWhere('power_up_level', onlyLevels)
}
const results = await query

const normalized = isMad
? this.mapMAD(results, safeTs)
: this.mapRDM(results, safeTs)
Expand Down Expand Up @@ -571,16 +585,25 @@ module.exports = class Pokestop extends Model {
'power_up_level',
'power_up_end_timestamp',
])
if (filters.onlyEventStops) {
filtered.invasions = pokestop.invasions.filter(
(invasion) => !invasion.grunt_type,
)
}
}
if (
perms.invasions &&
(filters.onlyAllPokestops || filters.onlyInvasions)
) {
filtered.invasions = filters.onlyAllPokestops
? pokestop.invasions
: pokestop.invasions.filter(
(invasion) => filters[`i${invasion.grunt_type}`],
)
filtered.invasions = [
...(Array.isArray(filtered.invasions) ? filtered.invasions : []),
...(filters.onlyAllPokestops
? pokestop.invasions
: pokestop.invasions.filter(
(invasion) =>
invasion.grunt_type && filters[`i${invasion.grunt_type}`],
)),
]
}
if (
perms.lures &&
Expand Down Expand Up @@ -715,7 +738,10 @@ module.exports = class Pokestop extends Model {
}
})
}
if (invasion.grunt_type && invasion.incident_expire_timestamp >= ts) {
if (
typeof invasion.grunt_type === 'number' &&
invasion.incident_expire_timestamp >= ts
) {
filtered[result.id].invasions.push(invasion)
}
filtered[result.id].quests.push(quest)
Expand Down Expand Up @@ -755,7 +781,10 @@ module.exports = class Pokestop extends Model {
if (altQuest.quest_reward_type) {
filtered[result.id].quests.push(altQuest)
}
if (invasion.grunt_type && invasion.incident_expire_timestamp >= ts) {
if (
typeof invasion.grunt_type === 'number' &&
invasion.incident_expire_timestamp >= ts
) {
filtered[result.id].invasions.push(invasion)
}
}
Expand Down Expand Up @@ -1070,11 +1099,17 @@ module.exports = class Pokestop extends Model {
} else {
queries.invasions = this.query()
.distinct(isMad ? 'incident_grunt_type AS grunt_type' : 'grunt_type')
.where(
isMad ? 'incident_grunt_type AS grunt_type' : 'grunt_type',
'>',
0,
)
.where(
isMad ? 'incident_expiration' : 'incident_expire_timestamp',
'>=',
isMad ? this.knex().fn.now() : ts,
)

.orderBy('grunt_type')
}
// invasions
Expand Down
3 changes: 3 additions & 0 deletions server/src/services/defaultFilters/buildDefaultFilters.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ module.exports = function buildDefault(perms, available, dbModels) {
? defaultFilters.pokestops.levels
: undefined,
lures: perms.lures ? defaultFilters.pokestops.lures : undefined,
eventStops: perms.pokestops
? defaultFilters.pokestops.eventStops
: undefined,
quests: perms.quests ? defaultFilters.pokestops.quests : undefined,
showQuestSet: defaultFilters.pokestops.questSet,
invasions: perms.invasions
Expand Down
1 change: 1 addition & 0 deletions server/src/services/ui/clientOptions.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ module.exports = function clientOptions(perms) {
clustering: { type: 'bool', perm: ['pokestops', 'quests', 'invasions'] },
invasionTimers: { type: 'bool', perm: ['invasions'] },
lureTimers: { type: 'bool', perm: ['lures'] },
eventStopTimers: { type: 'bool', perm: ['pokestops'] },
interactionRanges: { type: 'bool', perm: ['pokestops'] },
lureRange: { type: 'bool', perm: ['lures'] },
hasQuestIndicator: { type: 'bool', perm: ['quests'] },
Expand Down
1 change: 1 addition & 0 deletions src/components/Map.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ export default function Map({
(filters[category].lures && value.lures) ||
(filters[category].invasions && value.invasions) ||
(filters[category].quests && value.quests) ||
(filters[category].eventStops && value.eventStops) ||
(filters[category].arEligible && value.arEligible)) &&
!webhookMode
) {
Expand Down
16 changes: 10 additions & 6 deletions src/components/markers/pokestop.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,16 @@ export default function stopMarker(
if (hasInvasion) {
const { invasions } = pokestop
invasions.forEach((invasion) => {
filterId = `i${invasion.grunt_type}`
invasionIcons.unshift(Icons.getInvasions(invasion.grunt_type))
invasionSizes.unshift(Icons.getSize('invasion', filters.filter[filterId]))
popupYOffset += rewardMod.offsetY - 1
popupX += invasionMod.popupX
popupY += invasionMod.popupY
if (invasion.grunt_type) {
filterId = `i${invasion.grunt_type}`
invasionIcons.unshift(Icons.getInvasions(invasion.grunt_type))
invasionSizes.unshift(
Icons.getSize('invasion', filters.filter[filterId]),
)
popupYOffset += rewardMod.offsetY - 1
popupX += invasionMod.popupX
popupY += invasionMod.popupY
}
})
}
if (hasQuest && !(hasInvasion && invasionMod?.removeQuest)) {
Expand Down
7 changes: 5 additions & 2 deletions src/components/popups/Pokestop.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@ export default function PokestopPopup({
)
}, [])

const plainPokestop = !hasLure && !hasQuest && !hasInvasion
const hasEventInvasion = invasions?.some((invasion) => !invasion.grunt_type)

const plainPokestop =
!hasLure && !hasQuest && !hasInvasion && !hasEventInvasion

return (
<ErrorBoundary noRefresh style={{}} variant="h5">
Expand Down Expand Up @@ -142,7 +145,7 @@ export default function PokestopPopup({
/>
</>
)}
{hasInvasion && (
{(hasInvasion || hasEventInvasion) && (
<>
{(hasQuest || hasLure) && (
<Divider light flexItem className="popup-divider" />
Expand Down
17 changes: 16 additions & 1 deletion src/components/tiles/Pokestop.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ const PokestopTile = ({
item.invasions &&
item.invasions.some(
(invasion) =>
invasion.grunt_type &&
!excludeList.includes(`i${invasion.grunt_type}`) &&
invasion.incident_expire_timestamp > newTs,
)
Expand All @@ -50,6 +51,17 @@ const PokestopTile = ({
if ((showTimer || userSettings.lureTimers) && hasLure) {
timers.push(item.lure_expire_timestamp)
}
if (
(showTimer || userSettings.eventStopTimers) &&
!hasInvasion &&
item.invasions?.length
) {
item.invasions.forEach((invasion) => {
if (!invasion.grunt_type) {
timers.push(invasion.incident_expire_timestamp)
}
})
}

useMarkerTimer(
timers.length ? Math.min(...timers) : null,
Expand All @@ -66,7 +78,10 @@ const PokestopTile = ({
(hasQuest && perms.quests) ||
(hasLure && perms.lures) ||
(hasInvasion && perms.invasions) ||
((filters.allPokestops || item.ar_scan_eligible) && perms.allPokestops),
((filters.allPokestops ||
item.ar_scan_eligible ||
filters.eventStops) &&
perms.allPokestops),
) && (
<Marker
ref={(m) => {
Expand Down
4 changes: 3 additions & 1 deletion src/services/Query.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ export default class Query {
const permObj = {
Lures: filters.lures && perms.lures,
Quests: filters.quests && perms.quests,
Invasions: filters.invasions && perms.invasions,
Invasions:
(filters.invasions && perms.invasions) ||
(filters.eventStops && perms.allPokestops),
}
let query = 'get'

Expand Down