Create CODEOWNERS #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paco-barreras
pushed a commit
that referenced
this pull request
Oct 25, 2025
paco-barreras
added a commit
that referenced
this pull request
Nov 14, 2025
- Remove type hints from 5 functions (Principle #4) - Remove dead code: unused imports (pdb, cm), unused functions, unused variables - Fix broken reset_trajectory() cache nulling - Optimize O(n) → O(1) building lookups using indexed .loc[] (7 locations) - Remove defensive bloat: unnecessary .empty checks, hasattr checks - Remove bounds clamping (agents always kept in bounds by geometry checks) - Extract duplicate destination selection logic to helper function - Update test expectations: KeyError instead of IndexError for missing buildings - Add testing/environment notes to CODING_PRINCIPLES.md Results: 1491 → 1477 lines (-14 lines), all 14 tests pass Significant performance improvement from O(1) building lookups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.