fix: overflow of modal height

minheq · minheq · commit 9f65704f6d58 · 2019-01-16T15:40:41.000+07:00
diff --git a/src/components/Modal/ModalBase.web.tsx b/src/components/Modal/ModalBase.web.tsx
@@ -39,6 +39,7 @@ class ModalBase extends React.PureComponent<ModalBaseProps> {
     if (visible) {
       if (!isBackgroundScrollable) {
         document.body.style.overflow = 'hidden';
+        document.body.style.height = '100vh';
       }
 
       if (this.content.current) {
@@ -53,6 +54,7 @@ class ModalBase extends React.PureComponent<ModalBaseProps> {
     } else {
       if (!isBackgroundScrollable) {
         document.body.style.overflow = '';
+        document.body.style.height = '';
       }
     }
   }
@@ -76,6 +78,7 @@ class ModalBase extends React.PureComponent<ModalBaseProps> {
           backgroundColor: transparent ? 'transparent' : 'white',
           bottom: 0,
           left: 0,
+          overflow: 'auto',
           position: isBackgroundScrollable ? 'absolute' : 'fixed',
           right: 0,
           top: 0,

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,7 @@ class ModalBase extends React.PureComponent<ModalBaseProps> {`
`39`	`39`	`if (visible) {`
`40`	`40`	`if (!isBackgroundScrollable) {`
`41`	`41`	`document.body.style.overflow = 'hidden';`
	`42`	`+ document.body.style.height = '100vh';`
`42`	`43`	`}`
`43`	`44`
`44`	`45`	`if (this.content.current) {`
`@@ -53,6 +54,7 @@ class ModalBase extends React.PureComponent<ModalBaseProps> {`
`53`	`54`	`} else {`
`54`	`55`	`if (!isBackgroundScrollable) {`
`55`	`56`	`document.body.style.overflow = '';`
	`57`	`+ document.body.style.height = '';`
`56`	`58`	`}`
`57`	`59`	`}`
`58`	`60`	`}`
`@@ -76,6 +78,7 @@ class ModalBase extends React.PureComponent<ModalBaseProps> {`
`76`	`78`	`backgroundColor: transparent ? 'transparent' : 'white',`
`77`	`79`	`bottom: 0,`
`78`	`80`	`left: 0,`
	`81`	`+ overflow: 'auto',`
`79`	`82`	`position: isBackgroundScrollable ? 'absolute' : 'fixed',`
`80`	`83`	`right: 0,`
`81`	`84`	`top: 0,`