-
Notifications
You must be signed in to change notification settings - Fork 11
Fix styles barrel import, extract :root to globals.scss #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for webdevpathstage ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks. It's really handy.
|
Satoshi-Sh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!!
shayla-develops-webs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
oluwatobiss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate :root imports fixed. Thanks!
Have you updated the CHANGELOG.md file? If not, please do it.
yes
What is this change?
Fix styles barrel import
extract :root to globals.scss
:root should only be imported once in _app, so it should be taken off barrel import
Were there any complications while making this change?
no
How to replicate the issue?
n/a
If necessary, please describe how to test the new feature or fix.
When should this be merged?