Skip to content

Conversation

@cherylli
Copy link
Member

Have you updated the CHANGELOG.md file? If not, please do it.

yes

What is this change?

Fix styles barrel import
extract :root to globals.scss

:root should only be imported once in _app, so it should be taken off barrel import

Were there any complications while making this change?

no

How to replicate the issue?

n/a

If necessary, please describe how to test the new feature or fix.

When should this be merged?

@cherylli cherylli requested a review from a team July 23, 2025 14:04
@netlify
Copy link

netlify bot commented Jul 23, 2025

Deploy Preview for webdevpathstage ready!

Name Link
🔨 Latest commit e1d52cf
🔍 Latest deploy log https://app.netlify.com/projects/webdevpathstage/deploys/68878c28f7cd66000866efe2
😎 Deploy Preview https://deploy-preview-264--webdevpathstage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cherylli cherylli self-assigned this Jul 24, 2025
@Satoshi-Sh
Copy link
Member

Thanks. It's really handy.

BlogPostsContainer.modules.scss needs to be updated in this PR.

Copy link
Member

@Satoshi-Sh Satoshi-Sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!!

Copy link
Member

@shayla-develops-webs shayla-develops-webs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

Copy link
Member

@oluwatobiss oluwatobiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate :root imports fixed. Thanks!

@cherylli cherylli merged commit c4b35c5 into main Jul 29, 2025
4 checks passed
@cherylli cherylli deleted the styles/fix-barrel-import branch July 29, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants