Skip to content

Conversation

@cherylli
Copy link
Member

@cherylli cherylli commented Aug 1, 2025

Web Dev Path
238

Have you updated the CHANGELOG.md file? If not, please do it.

yes

What is this change?

  • convert TwoColumn styles back to scss
  • update TwoColumn usage in index, about, and blogpostcontainer

Were there any complications while making this change?

no

How to replicate the issue?

n/a

If necessary, please describe how to test the new feature or fix.

When should this be merged?

After review

image image image

@cherylli cherylli requested a review from a team August 1, 2025 15:15
@cherylli cherylli self-assigned this Aug 1, 2025
@netlify
Copy link

netlify bot commented Aug 1, 2025

Deploy Preview for webdevpathstage ready!

Name Link
🔨 Latest commit 3df070a
🔍 Latest deploy log https://app.netlify.com/projects/webdevpathstage/deploys/68932339052cb300074bc12a
😎 Deploy Preview https://deploy-preview-268--webdevpathstage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@shayla-develops-webs shayla-develops-webs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@cherylli cherylli requested a review from Satoshi-Sh August 5, 2025 09:09
Copy link
Member

@Satoshi-Sh Satoshi-Sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the updates

Copy link
Member

@briangesteban briangesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a minor discrepancy on styling, it seems that the button on the about page > wanna learn more section should be pushed down to the containers' height.

Reference Image:
ref-gap

Copy link
Member

@oluwatobiss oluwatobiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@cherylli cherylli merged commit 00115fa into main Aug 6, 2025
4 checks passed
@cherylli cherylli deleted the styles/to-scss-two-column-v2 branch August 6, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants