Refactor scss CardContainer #280
Conversation
remove unused Card files update CHANGELOG
✅ Deploy Preview for webdevpathstage ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Satoshi-Sh
left a comment
Satoshi-Sh
left a comment
There was a problem hiding this comment.
If you see the same styling property on the browser, I believe you don't need to worry about the differences of the look.
oluwatobiss
left a comment
oluwatobiss
left a comment
There was a problem hiding this comment.
Thanks, @shayla-develops-webs, for your work on this PR!
Concerning the complication you noted, the title text appears smaller after the change because .title’s font family should be $font-family-secondary rather than var(--font-heading).
Please consider the additional suggestions I’ve made.
There was a problem hiding this comment.
@shayla-develops-webs
Thank you for the refactoring! Regarding your concern below, the cause is a difference in font types. As shown in the images, production uses "Open Sans," while this PR uses "Assistant." This issue can be fixed by using $font-family-secondary as @oluwatobiss suggested here.
Were there any complications while making this change?
Yes. I need some assistance figuring why the title text on the blog card is smaller after the change.
The blog card variant title text is rendering smaller than intended, even though the SCSS override exists. The nested .card--blog .title styles don’t appear to be applying the expected font size.
[styles/_variables.scss]
[Production] "Open Sans" is used
[PR#280] "Assistant" is used
… added title attribute to h2 element
|
Thank you @oluwatobiss and @mtkksk1780 for the suggestions! |
Satoshi-Sh
left a comment
Satoshi-Sh
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for the update 👍
…nto Refactor/to-scss-CardContainer
…nto Refactor/to-scss-CardContainer
oluwatobiss
left a comment
oluwatobiss
left a comment
There was a problem hiding this comment.
LGTM. Thanks @shayla-develops-webs!
remove unused Card files
update CHANGELOG
Have you updated the CHANGELOG.md file? If not, please do it.
yes
What is this change?
migrated the containers>card components to scss modules
Were there any complications while making this change?
Yes. I need some assistance figuring why the title text on the blog card is smaller after the change.
The blog card variant title text is rendering smaller than intended, even though the SCSS override exists. The nested .card--blog .title styles don’t appear to be applying the expected font size.
here is before:
here is after migration:
How to replicate the issue?
temporarily edit the scss title size and see if it changes for you
If necessary, please describe how to test the new feature or fix.
n/a
When should this be merged?
after fix and review