Skip to content

Conversation

@grvgoel81
Copy link
Contributor

@grvgoel81 grvgoel81 commented Sep 14, 2024

Motivation and Context

  • Update sfa android deps and code changes related to session manager and SFA.
  • Rename getKey() function to connect() function.
  • Remove getAggregateTorusKey() function and connect function can be used for getAggregateTorusKey() function.
  • Update sfa swift deps and code related changes.

Jira Link: https://toruslabs.atlassian.net/browse/PD-3896

Description

  • Update sfa android deps and code changes related to session manager and SFA.
  • Rename getKey() function to connect() function.
  • Remove getAggregateTorusKey() function and connect function can be used for getAggregateTorusKey() function.
  • Update sfa swift deps and code related changes.

How has this been tested?

  • Tested on android and iOS emulators.

Screenshots (if appropriate):

Screen.Recording.2024-09-14.at.3.44.33.PM.mov
Screen.Recording.2024-09-19.at.7.57.57.AM.mov

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…ager and sfa

Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81 grvgoel81 marked this pull request as ready for review September 19, 2024 05:35
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 3628adb into master Sep 19, 2024
@chaitanyapotti chaitanyapotti deleted the update-sfa-sndroid-version branch September 19, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants