Skip to content

Conversation

@grvgoel81
Copy link
Contributor

@grvgoel81 grvgoel81 commented Sep 24, 2024

Motivation and Context

  • Remove isSessionIdExists() method.
  • Modified LoginParams to make it consistenst similar to SFA sdk's.
  • logout method added.
  • getSessionData() method added.

Jira Link: https://toruslabs.atlassian.net/browse/PD-4239

Description

  • Remove isSessionIdExists() method.
  • Modified LoginParams to make it consistenst similar to SFA sdk's.
  • logout method added.
  • getSessionData() method added.
  • Update example.

How has this been tested?

By testing on android and iOS emulator.

Screenshots (if appropriate):

Screen.Recording.2024-12-06.at.10.05.08.AM.mov
Screen.Recording.2024-12-06.at.10.10.47.AM.mov

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

grvgoel81 and others added 13 commits September 24, 2024 14:24
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81 grvgoel81 marked this pull request as ready for review December 4, 2024 09:07
grvgoel81 and others added 11 commits December 4, 2024 14:44
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 255949b into master Feb 27, 2025
@chaitanyapotti chaitanyapotti deleted the feat/updates branch February 27, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants