Skip to content

Conversation

@grvgoel81
Copy link
Contributor

Motivation and Context

Swift better error handling

Jira Link:

Description

  • Swift better error handling.
  • Previously there is generic error everytime "privateKeyNot Generated Error" but after update it gives exact error like "retrieve or import share failed" in screenshot.

How has this been tested?

Screenshots (if appropriate):

Screenshot 2024-11-07 at 11 30 00 AM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@metalurgical
Copy link

This is much better thanks.

Please also remove this function as well:

public func throwKeyNotGeneratedError() -> FlutterError

Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
Copy link
Contributor Author

This is much better thanks.

Please also remove this function as well:

public func throwKeyNotGeneratedError() -> FlutterError

done.

Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 3dfab48 into master Nov 8, 2024
@chaitanyapotti chaitanyapotti deleted the swift-better-error-handling branch November 8, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants