Skip to content

Feat/wallet services integration #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Apr 7, 2025
Merged

Feat/wallet services integration #19

merged 35 commits into from
Apr 7, 2025

Conversation

@grvgoel81
Copy link
Contributor

@grvgoel81 grvgoel81 commented Dec 19, 2024 •
edited
Loading

Motivation and Context

  • Wallet-services added.
  • request() function(signatures) added.
  • bump wallet-services to v4 version.
  • Add ProGuard rules for classes to prevent obfuscation.

Jira Link: https://toruslabs.atlassian.net/browse/PD-4247, https://toruslabs.atlassian.net/browse/PD-4251, https://toruslabs.atlassian.net/browse/PD-4257

Description

Wallet-services added.

  • Wallet-services added.
  • request() function(signatures) added.
  • bump wallet-services to v4 version.
  • Add ProGuard rules for classes to prevent obfuscation.

How has this been tested?

  • Tested on emulator

Screenshots (if appropriate):

Screen.Recording.2025-04-04.at.7.31.17.AM.mov

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

grvgoel81 and others added 11 commits December 18, 2024 12:16
@grvgoel81
feat: wallet-services and request function added in flutter and andro…
1ab433a 
…id side.

Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: update input.dart, add enums in separate file
6f47f67 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: update signaturesData in SessionData schema
edd315b 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: replace launchWalletServices with showWalletUI function name.
715c77c 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: update context in SingleFactorAuthFlutterPlugin.kt
453041f 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: remove extra logs
53525a1 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: return null in case user not loggedIn.
0d3d393 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
add redirectUrl
4ccc26b 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: change redirectUrl dataType to String.
3d0d427 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: update example
84aecc2 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: showWalletUI and request function added in SingleFactorAuthFlut…
c669bcc 
…terPlugin.swift

Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81 grvgoel81 marked this pull request as ready for review February 3, 2025 03:36
grvgoel81 and others added 12 commits February 17, 2025 15:34
@grvgoel81
feat: mid-commit
ad87d25 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: bump SFA android sdk
1e7f924 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
Merge branch 'master' into feat/wallet-services_integration
cb5616e
@grvgoel81
feat: bump SFA android sdk
9fdcb54 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: bump wallet-services version
06acc5f 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
Merge branch 'master' into feat/wallet-services_integration
6890c73
@grvgoel81
feat: bump ios version
f0e4b25 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: bump android version
d0929a8 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: bump gradle-wrapper.properties distributionUrl
56ec479 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: add proguard-rules foe classes for obsfuscation.
78c6ac2 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
Merge branch 'feat/sfa_android_updates' into feat/wallet-services_int…
7b9558b 
…egration

# Conflicts:
#	android/build.gradle
#	android/src/main/kotlin/com/web3auth/single_factor_auth_flutter/SingleFactorAuthFlutterPlugin.kt
@grvgoel81
feat: made redirectUrl as optional and add redirectUrl in Swift side.
e984cf7 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81 grvgoel81 mentioned this pull request Apr 4, 2025
Closed
9 tasks
@AyushBherwani1998
Copy link
Member

AyushBherwani1998 commented Apr 4, 2025

untitled.webm
Simulator.Screen.Recording.-.iPhone.15.-.2025-04-04.at.10.27.47.mp4

PR looks, good. Only thing remaining is that I'm not able to get the private key in release mode. @grvgoel81 need to test and confirm.

grvgoel81 and others added 4 commits April 4, 2025 12:19
@grvgoel81
feat: add proguard-rules foe classes for obsfuscation.
25863a9 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: add consumer-rules.pro
b1ebf2a 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: add @keep to each data class and its members
e41fa14 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: update sfa android version
c3ce207 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
grvgoel81 and others added 8 commits April 4, 2025 16:21
@grvgoel81
feat: update sfa android version
2eb255f 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: update sfa android version and proguard-rules.pro
737122c 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: update consumer-rules.pro
811a0b2 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: update consumer-rules.pro for bouncycastle library
ee3118e 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
add rule for FND in proguard-rules.pro
b04df27 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: bump android sdk
0e55d9a 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: bump sfa android sdk
eb6a2c2 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
Update proguard-rules.pro
0a7f2d0
chaitanyapotti
chaitanyapotti approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit eb3f226 into master Apr 7, 2025
@chaitanyapotti chaitanyapotti deleted the feat/wallet-services_integration branch April 7, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@grvgoel81 @AyushBherwani1998 @chaitanyapotti