Skip to content

Fix session data on iOS #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 5, 2025
Merged

Fix session data on iOS #23

merged 4 commits into from
Mar 5, 2025

Conversation

@AyushBherwani1998
Copy link
Member

@AyushBherwani1998 AyushBherwani1998 commented Mar 3, 2025 •
edited by grvgoel81
Loading

Motivation and Context

Jira Link:

Description

  • Fixes the encoding issue of getSessionData, and removes call of initialize in getSessionData()
  • Update Example

How has this been tested?

  • On Emulator

Screenshots (if appropriate):

Screen.Recording.2025-03-05.at.7.55.36.AM.mov
Screen.Recording.2025-03-05.at.8.20.02.AM.mov

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

AyushBherwani1998 and others added 3 commits March 3, 2025 14:45
@AyushBherwani1998
fix session data issue on ios
446c22a
@grvgoel81
feat: update example and moved initialize out of getSessionData()
05a0936 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: bump sdk version
dd208c7 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
grvgoel81
grvgoel81 approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@grvgoel81 grvgoel81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

AyushBherwani1998
AyushBherwani1998 commented Mar 5, 2025
View reviewed changes
@grvgoel81
feat: update main.dart
fdd5818 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
chaitanyapotti
chaitanyapotti approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 988fc77 into master Mar 5, 2025
@chaitanyapotti chaitanyapotti deleted the fix/session-data-ios branch March 5, 2025 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grvgoel81 grvgoel81 grvgoel81 approved these changes

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AyushBherwani1998 @chaitanyapotti @grvgoel81