Skip to content

Conversation

grvgoel81
Copy link
Contributor

@grvgoel81 grvgoel81 commented Sep 17, 2024

Motivation and Context

  • Update session-manager-android sdk.
  • Update authService version to v9 and walletServices to v3.

Jira Link: https://toruslabs.atlassian.net/browse/PD-3861

Description

  • Update session-manager-android sdk and related changes wrt API method parameters.
  • Update authService version to v9 and walletServices to v3.

How has this been tested?

  • Tested all functionalities like login, logout, session management ,walletservices, setupMFA and request() method.

Screenshots (if appropriate):

Screen.Recording.2024-11-25.at.9.31.55.AM.mov

For request method changes:

Screen.Recording.2024-10-23.at.11.18.00.AM.mov

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@metalurgical
Copy link
Contributor

metalurgical commented Oct 30, 2024

Merge #72 into this before merging to master.

@metalurgical
Copy link
Contributor

metalurgical commented Nov 15, 2024

Note #74 must be merged before this PR, then this PR must be rebased on top of it.

Done.

Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 12f4099 into master Nov 25, 2024
2 checks passed
@chaitanyapotti chaitanyapotti deleted the update_session_manager_and_v9_updates branch November 25, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants