Build binaryen.js and wasm.js #1260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es, so add them as necessary
Member
Author
|
I'll land this since we have various PRs in flight that could benefit from this additional testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds CI testing to verify that building binaryen.js and wasm.js works. It uses the docker image and method suggested on these new docs.
This does add to our CI times, but not much actually, the new job is the shortest of all the seven, just 4 minutes (next is 5.5 minutes, median is 6.75).
Note that this doesn't test the generated JS files, it just checks for compilation errors. But that should already be helpful as this does break from time to time.