Generalize EM_JS parsing code. #2233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e constant, which may or may not be saved/loaded from a local, and may or may not get an added global if in relocatable code
This was referenced Jul 18, 2019
jgravelle-google
approved these changes
Jul 18, 2019
| // An EM_JS has a single const in the body. Typically it is just returned, | ||
| // but in unoptimized code it might be stored to a local and loaded from | ||
| // there, and in relocatable code it might get added to __memory_base etc. | ||
| FindAll<Const> consts(curr->body); |
Contributor
There was a problem hiding this comment.
Oh man a Const-finder? That's way nicer :D
kripken
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Jul 20, 2019
Depends on WebAssembly/binaryen#2233 Bug report: #8993
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key thing is that there is a single constant, which may or may not be saved/loaded from a local, and may or may not get an added global if in relocatable code.
Fixes emscripten-core/emscripten#8993