Skip to content

Conversation

@kripken
Copy link
Member

@kripken kripken commented Jan 24, 2023

Nested runners should be ignored, as they run some internal stuff in
certain passes, which would not contain the pass the user asked to
skip with --skip-pass.

Diff without whitespace is trivial.

@kripken kripken requested a review from tlively January 24, 2023 23:41
@tlively
Copy link
Member

tlively commented Jan 25, 2023

I could see this being somewhat confusing for passes like inlining that run an entire optimization pipeline in a nested pass runner, but I don't know that it would be worth the extra complexity to "fix" that.

@kripken
Copy link
Member Author

kripken commented Jan 25, 2023

Good point, this would miss the nested full pipeline run of wasm-opt --inlining-optimizing. But yeah, not worth it to fix I think.

@kripken kripken merged commit 720d644 into main Jan 25, 2023
@kripken kripken deleted the skip.fix branch January 25, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants