Skip to content

Conversation

@kripken
Copy link
Member

@kripken kripken commented Feb 2, 2023

If we see

(struct.new $A
  (call $call.without.effects ;; intrinsic
    (ref.func $getter)
  )
)

then we can ignore side effects in that call, as the intrinsic tells us to. However,
that function is still called (it will be called normally, after intrinsics are lowered
away), and we should not remove it.

We can perhaps do better here, but I'm not sure yet. Leaving that as a TODO.

This fixes breakage on J2Wasm.

@kripken kripken requested a review from tlively February 2, 2023 19:14
@kripken kripken merged commit 91f54df into main Feb 2, 2023
@kripken kripken deleted the rume.effects branch February 2, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants