OptimizeInstructions: Simplify tuple.extract of tuple.make #5938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5938 +/- ##
==========================================
+ Coverage 42.60% 42.61% +0.01%
==========================================
Files 484 484
Lines 74815 74822 +7
Branches 11919 11920 +1
==========================================
+ Hits 31872 31883 +11
+ Misses 39746 39745 -1
+ Partials 3197 3194 -3
|
tlively
approved these changes
Sep 14, 2023
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
…ly#5938) E.g. (tuple.extract 1 (tuple.make (A) (B) (C)) => (B) Modify some existing tests to not be in this trivial form, so that they do not stop testing what they should.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(tuple.extract 1 (tuple.make (A) (B) (C)) => (B)Modify some existing tests to not be in this trivial form, so that they do not
stop testing what they should.