[GC] Fix assertion in GlobalTypeOptimization about public super #7026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Oct 21, 2024
| ;; cannot remove the unused i32 field from its child or grandchild. | ||
| (module | ||
| ;; CHECK: (type $A (sub (struct (field (mut i32))))) | ||
| (type $A (sub (struct (field (mut i32))))) |
Member
There was a problem hiding this comment.
Should we also add a test where the field is not present on $A, so it can still be removed from $B and $C?
Member
Author
There was a problem hiding this comment.
Good catch, this was actually a bug. The loop on supers here would need to also handle the super not having the field, mirroring the code elsewhere.
Overall this seems to make the assertion more and more complex, past the point of being worth it, so I removed it. We do still cover this in depth in tests.
tlively
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only checked for the case of the immediate super being public while we
are private, but it might be a grandsuper instead. That is, any ancestor that
is public will prevent GTO from removing a field (since we can only add
fields on top of our ancestors).