Validate drop #712
Merged
Validate drop #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
force-pushed
the
validate-drop
branch
from
91e5131 to
be83fa5
Compare
kripken
force-pushed
the
validate-drop
branch
from
be83fa5 to
af1edd9
Compare
|
s2wasm was fixed, and I also fixed the issue noted in #718 (comment), so this should be good to go now. |
dschuff
approved these changes
Sep 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the validator enforce drop being used on a value that is droppable. Apparently no spec test checks this, so it wasn't done already. The new pass fuzzer noticed this.
Spec tests are updated here since the previous version had some incorrect drops (which I meanwhile noticed and fixed in WebAssembly/spec#351.
This can't be merged yet due to #708, we need to fix either the wasm backend or s2wasm to emit proper drops, so they pass this new validation.