Fuzzer: Add call-ref, call-ref-catch imports #7137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Dec 6, 2024
| target = callExportImportName; | ||
| } else if (type == Type::i32) { | ||
| target = callExportCatchImportName; | ||
| if (type == Type::i32) { |
Member
There was a problem hiding this comment.
The comment below that says "This never traps.. but we do still want to avoid trapping..." seems to contradict itself about whether traps are possible. Can we clarify it?
Member
Author
There was a problem hiding this comment.
Clarified. The issue is swallowing traps: we always swallow them, but still prefer not to have any trap at all.
Member
There was a problem hiding this comment.
Should this also say "exceptions" instead of "traps"?
Member
Author
There was a problem hiding this comment.
😆 yeah, sorry, it seems I have difficulty not using "trap" as a catchall for "error". fixed.
Co-authored-by: Thomas Lively <tlively123@gmail.com>
Co-authored-by: Thomas Lively <tlively123@gmail.com>
Co-authored-by: Thomas Lively <tlively123@gmail.com>
Co-authored-by: Thomas Lively <tlively123@gmail.com>
tlively
approved these changes
Dec 6, 2024
Co-authored-by: Thomas Lively <tlively123@gmail.com>
tlively
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
call-export*, these imports call a wasm function from outside themodule. The difference is that we send a function reference for them to call
(rather than an export index).
This gives more coverage, first by sending a ref from wasm to JS, and also
since we will now try to call anything that is sent. Exports, in comparison,
are filtered by the fuzzer to things that JS can handle, so this may lead to
more traps, but maybe also some new situations. This also leads to adding
more logic to
execution-results.hto model JS trapping properly.fuzz_shell.jsis refactored to allow sharing code betweencall-export*andcall-ref*.