[NFC] Simplify TypeGraphWalker in wasm-type.cpp #7143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-locate the declaration and implementation of TypeGraphWalkerBase and its subtypes in wasm-type.cpp and simplify the implementation. Remove the preVisit and postVisit tasks for both Types and HeapTypes since overriding scanType and scanHeapType is sufficient for all users. Stop scanning the HeapTypes in reference types because a follow-on change (#7142) will make that much more complicated, and it turns out that it is not necessary.
kripken
reviewed
Dec 10, 2024
| assert(taskList.empty()); | ||
| taskList.push_back(Task::scan(type)); | ||
| doWalk(); | ||
| } |
Member
There was a problem hiding this comment.
As we don't walk heap types, it seems like this will only ever walk the type itself, or the tuple elements if it is a tuple. And the tuple elements are not themselves tuples. So can this function not just be a simple loop over *type?
Member
Author
There was a problem hiding this comment.
It could, but I think it's simpler to keep the method of traversal consistent between types and heap types.
Member
There was a problem hiding this comment.
Fair enough, though it might be a tad faster the other way. But up to you.
src/wasm/wasm-type.cpp
Outdated
|
|
||
| private: | ||
| bool isTopLevel = true; | ||
| std::unordered_set<HeapType> seen; |
kripken
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-locate the declaration and implementation of TypeGraphWalkerBase and
its subtypes in wasm-type.cpp and simplify the implementation. Remove
the preVisit and postVisit tasks for both Types and HeapTypes since
overriding scanType and scanHeapType is sufficient for all users. Stop
scanning the HeapTypes in reference types because a follow-on change
(#7142) will make that much more complicated, and it turns out that it
is not necessary.