Skip to content

Address comments from #7149 #7152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Address comments from #7149 #7152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ Current Trunk

- BinaryenSelect no longer takes a type parameter.
- AutoDrop APIs have been removed.
- Binaryen now supports parsing control flow structures with parameter types.
- Binaryen now supports parsing control flow structures with parameter types by
lowering them away in the parsers..

v120
----
Expand Down
2 changes: 1 addition & 1 deletion src/wasm-binary.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1467,7 +1467,7 @@ class WasmBinaryReader {

bool getBasicType(int32_t code, Type& out);
bool getBasicHeapType(int64_t code, HeapType& out);
// Get the signature of control flow structure.
// Get the signature of a control flow structure.
Signature getBlockType();
// Read a value and get a type for it.
Type getType();
Expand Down
Loading