Fix a text parser assertion on bad immediates #7252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously asserted that the end of a nested expression is the same when we parse it with a null context just to find its children and when we parse it for real. It turns out that it is possible for the two end positions to be different when the instruction is invalid in a way that only the real parse catches. Return a normal error instead of asserting because it is possible for invalid input to trigger this condition. Fixes #7251.
kripken
approved these changes
Jan 30, 2025
| if (ctx.in.getPos() != *info.end) { | ||
| return ctx.in.err("expected end of instruction"); | ||
| } | ||
| assert(ctx.in.getPos() == *info.end && "expected end of instruction"); |
tlively
added a commit
that referenced
this pull request
Jan 30, 2025
This should have been removed in #7252.
tlively
added a commit
that referenced
this pull request
Jan 30, 2025
This should have been removed in #7252.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously asserted that the end of a nested expression is the same
when we parse it with a null context just to find its children and when
we parse it for real. It turns out that it is possible for the two end
positions to be different when the instruction is invalid in a way that
only the real parse catches. Return a normal error instead of asserting
because it is possible for invalid input to trigger this condition.
Fixes #7251.