Fix cross-module call_indirects in the interpreter #7964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Oct 9, 2025
|
|
||
| auto* func = self()->getModule()->getFunction(funcref.getFunc()); | ||
| if (!HeapType::isSubType(func->type, curr->heapType)) { | ||
| if (!HeapType::isSubType(funcref.type.getHeapType(), curr->heapType)) { |
Member
There was a problem hiding this comment.
Let's add a TODO about throwing a non-constant exception here if the reference is to an imported function that has a supertype of the expected type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was using the name of the function to look up the funcref in the current
module. Instead, use
doCallso we can call another module's function.