[GC] Fix name updating in GTO when only some fields are named #7986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Oct 23, 2025
| for (Index i = 0; i < oldFieldNames.size(); i++) { | ||
| for (Index i = 0; i < indexesAfterRemoval.size(); i++) { | ||
| auto newIndex = indexesAfterRemoval[i]; | ||
| if (newIndex != RemovedField && oldFieldNames.count(i)) { |
Member
There was a problem hiding this comment.
Could use oldFieldNames.find() to remove the number of map lookups while we're here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating field names, that pass looped over the number of
field names. If all fields are named, that is fine, but if only some are,
we did not reach later ones.
Fixes #7982