[NFC] Non-recursive wildcard matching #7988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a non-recursive wildcard matching algorithm that pushes and pops the search stack as little as possible. It pushes only when it must decide whether or not to have a wildcard consume a character that it could also plausibly not consume.
Member
Author
|
(The last commit makes this simpler but possibly way slower, so it's mostly just to illustrate how simple this can get.) |
kripken
approved these changes
Oct 23, 2025
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
lgtm, both solutions seem fine and this one may be faster.
Please copy the test from the other PR.
This reverts commit 0010467.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a non-recursive wildcard matching algorithm that pushes and pops the search stack as little as possible. It pushes only when it must decide whether or not to have a wildcard consume a character that it could also plausibly not consume.