Add a logo [NFC] #8102
Merged
Add a logo [NFC] #8102
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Here's the optimized version of this:
Replace what you have with the contents of this file, and LGTM. I actually quite like it! |
tomayac
approved these changes
Dec 9, 2025
Contributor
tomayac
left a comment
tomayac
left a comment
There was a problem hiding this comment.
LGTM with an optimization nit.
Member
Author
|
Thanks @tomayac ! |
Member
|
Interestingly the optimized version renders fine here in the comments, but if I right click it and "open link in new tab" I get this garbage: |
Member
|
And I get slightly different garbage when I "open image in new tab" on the one that is live on the readme: |
Member
Author
|
Huh, that's really weird... happens in both Firefox and Chrome, so it's not a browser bug. And it renders ok in Inkscape and other offline tools. Only "open image in new tab" and "open link in new tab" look broken |
Contributor
|
It's a CSP thing. It contains three base64-encoded images used for masking. They work fine when loading the SVG standalone in an
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process:
Someone with artistic talent could surely do better, of course...
Context: We may want to add binaryen to the wasm website, and all other
projects there have logos...
View it here: https://github.com/kripken/binaryen/blob/logo/README.md