This repository was archived by the owner on Apr 25, 2025. It is now read-only.
Describe JS API for GC #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewagner
force-pushed
the
add-js-api
branch
from
ca58ba0 to
66e2edf
Compare
chicoxyzzy
reviewed
Nov 6, 2018
Member
Author
binji
reviewed
Nov 10, 2018
Member
binji
left a comment
binji
left a comment
There was a problem hiding this comment.
Interesting read, thanks! Just one comment
Contributor
|
I've read most of this PR but I need a day or two to chew on the part about nominal types and importing. |
titzer
reviewed
Nov 14, 2018
jacobp100
reviewed
Feb 25, 2019
Contributor
|
Ok, I've looked through this again and refreshed myself on it. I think it is sufficiently baked that we should land and iterate on it, particularly around the nominal/structural subtyping issues. I don't see any reason to hold it up for that. So, lgtm, and sorry for the long delay on this. |
added 9 commits
April 4, 2019 19:30
Member
Author
|
Thanks for the looking through this. Agreed we'll want to continue iterating on the structural/nominal design. |
rossberg
pushed a commit
that referenced
this pull request
Feb 24, 2021
The order of the `table.init` and `memory.init` immediates should be the index followed by the reserved byte (which is a placeholder for the table or memory index). This matches ordering of immediates in `call_indirect` (type index, followed by table index reserved byte).
rossberg
pushed a commit
that referenced
this pull request
Feb 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the stub "JS API" section out of MVP.md into a new MVP-JS.md that defines the JS API in terms of the JS Typed Objects proposal.