This repository was archived by the owner on Dec 22, 2021. It is now read-only.
[test] Integrate latest v128 constant tests #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New tests for 64x2 constant and more literal testing per WAVM/WAVM#195
tlively
approved these changes
Nov 4, 2019
| ) | ||
| (assert_malformed | ||
| (module quote "(func (v128.const i8x16 0x 0x 0x 0x 0x 0x 0x 0x 0x 0x 0x 0x 0x 0x 0x 0x) drop)") | ||
| "unknown operator" |
Member
There was a problem hiding this comment.
Why is this message "unknown operator" instead of something more specifically about malformed constants? Changing it would be out of scope here, obviously, but I am curious.
Contributor
Author
There was a problem hiding this comment.
Wasm interpreter verifies all error messages but WAVM doesn't.
In current interpreter, "unknown operator" contains malformed constants. That's why it's unknown operator here. But there should be a specific message for malformed constants, it's a new feature request for interpreter. :)
Honry
added a commit
to Honry/simd
that referenced
this pull request
Mar 11, 2020
Honry
added a commit
to Honry/simd
that referenced
this pull request
Mar 11, 2020
Fixed @binji's comment at WebAssembly#132 (comment)
Honry
added a commit
to Honry/simd
that referenced
this pull request
Mar 11, 2020
Fixed @binji's comment at WebAssembly#132 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New tests for 64x2 constant and more literal
testing per WAVM/WAVM#195