Skip to content
This repository was archived by the owner on Dec 22, 2021. It is now read-only.

Conversation

@alexcrichton
Copy link
Contributor

The assert_invalid directive isn't intended to be used with (module quote ...) and the module quote part can be removed here as well
since the module should successfully parse, but fail to validate.

The `assert_invalid` directive isn't intended to be used with `(module
quote ...)` and the `module quote` part can be removed here as well
since the module should successfully parse, but fail to validate.
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Alex! @Honry is there corresponding test generation code that needs to be updated here?

@Honry
Copy link
Contributor

Honry commented Feb 5, 2020

Thanks @alexcrichton! @tlively no necessary, as it is out of test generation code, pls. land it. (BTW, sorry for late response.)

@tlively tlively merged commit 093ecb8 into WebAssembly:master Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants