This repository was archived by the owner on Dec 22, 2021. It is now read-only.
Specify binary format for SIMD #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binji
approved these changes
Aug 28, 2020
| .. math:: | ||
| \begin{array}{llclll} | ||
| \production{instruction} & \Binstr &::=& \dots \\&&|& | ||
| \hex{FD}~~12{:}\Bu32~~(b{:}\Bbyte)^{16} &\Rightarrow& \V128.\VCONST~ |
Member
There was a problem hiding this comment.
I wonder if this should use a function defined in values.rst, like the others? Maybe it's better to keep all SIMD stuff here.
Member
Author
There was a problem hiding this comment.
I think this should stay here, because this is about how the instruction treats its immediates. values.rst describes how integers are encoded in binary, and already covers a 128-bit integer. It might be confusing to describe how v128.const treats the bytes in the value section.
Member
Author
|
cc @rossberg, i'll merge this in first, have a text format change that depends on this, please leave comments when you get to this and i'll be happy to make edits, thanks! |
rossberg
reviewed
Sep 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.