This repository was archived by the owner on Dec 22, 2021. It is now read-only.
[interpreter] Implement load lane instructions #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v128.load8_lane v128.load16_lane v128.load32_lane v128.load64_lane Introduce a new ast type, SimdLoadLane, since it takes a lane index immediate, on top of the usual memarg, and also pops a v128 off, in addition to the index. The exact binary opcodes for these instructions are not yet fixed, I've used the ones currently implement in V8 and LLVM/Binaryen, we can change those later. Also added a new test generation script, and the generated test files.
rossberg
reviewed
Jan 26, 2021
rossberg
reviewed
Jan 27, 2021
rossberg
approved these changes
Jan 28, 2021
interpreter/exec/eval.ml
Outdated
| | None -> assert false | ||
| | Some (pack_size, laneidx) -> Memory.load_simd_lane v128 pack_size mem addr offset ty laneidx | ||
| | None -> Memory.load_value mem addr offset ty | ||
| | Some (pack_size, simd_load) -> V128 (Memory.load_simd_packed pack_size simd_load mem addr offset ty) |
Member
Author
There was a problem hiding this comment.
Thanks. Slight off-topic, would having some sort of formatter run on our input files be valuable? That would help codify and catch some of these stylistic issues.
I recognize that the big problem might be tons of merge conflicts when merging spec back into the proposals though...
Member
There was a problem hiding this comment.
Yeah, unfortunately, with all the active forks, we cannot make structural changes to the sources without creating a lot of pain for a lot of people. That also prevents some refactoring in the interpreter that I'd like to do (like pulling symbol resolution out of the parser).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v128.load8_lane
v128.load16_lane
v128.load32_lane
v128.load64_lane
Introduce a new ast type, SimdLoadLane, since it takes a lane index
immediate, on top of the usual memarg, and also pops a v128 off, in
addition to the index.
The exact binary opcodes for these instructions are not yet fixed, I've
used the ones currently implement in V8 and LLVM/Binaryen, we can change
those later.
Also added a new test generation script, and the generated test files.