Skip to content
This repository was archived by the owner on Dec 22, 2021. It is now read-only.

Conversation

@tlively
Copy link
Member

@tlively tlively commented Jan 24, 2019

As discussed in #55.

@tlively tlively changed the title V128 const text v128.const text Jan 24, 2019
v128.const i32x4 i32 i32 i32 i32
v128.const i64x2 i64 i64
v128.const f32x4 f32 f32 f32 f32
v128.const f64x2 f64 f64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to keep the text format separate from the design and binary format as this concerns only handwritten wasm tests or debug views of modules. Can we move all text format descriptions in its own section.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arunetm the text format will need to be the final spec as well, so it's not just a tool convention. The operations section of SIMD.md also already contains the names of every instruction in the style of the text format chapter of the specification, so I'm not sure this is out of place with respect to the other content in this file. I'm happy to move it, though, if you think that makes more sense. Would you want a separate file specifically for the text format analogous to BinarySIMD.md for the binary encoding?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need Text format to be part of the final spec. However, it's better to separate it from the types and operations ensuring that any references remain consistent. Agree that this is not critical until we have the formal spec, but I think its the right thing to do.
I suggest having a separate file analogous to BinarySIMD.md for text format. Also the added benefit of having a single place to refer to for people hand coding wasm modules.

@arunetm
Copy link
Collaborator

arunetm commented Jan 28, 2019

:shipit:

@tlively tlively merged commit 54fdb47 into master Jan 28, 2019
@dtig dtig deleted the v128-const-text branch September 4, 2019 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants