[test] Correct tests for missing elements #1251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
added a commit
to wasmx/fizzy
that referenced
this pull request
Sep 29, 2020
The upstream fix for newly discovered spectests issue is in WebAssembly/spec#1251.
rossberg
approved these changes
Sep 29, 2020
chfast
added a commit
to wasmx/fizzy
that referenced
this pull request
Sep 29, 2020
The upstream fix for newly discovered spectests issue is in WebAssembly/spec#1251.
chfast
added a commit
to wasmx/fizzy
that referenced
this pull request
Sep 29, 2020
The upstream fix for newly discovered spectests issue is in WebAssembly/spec#1251.
chfast
added a commit
to wasmx/fizzy
that referenced
this pull request
Oct 29, 2020
The upstream fix for newly discovered spectests issue is in WebAssembly/spec#1251.
chfast
added a commit
to wasmx/fizzy
that referenced
this pull request
Nov 3, 2020
The upstream fix for newly discovered spectests issue is in WebAssembly/spec#1251.
chfast
added a commit
to wasmx/fizzy
that referenced
this pull request
Nov 6, 2020
The upstream fix for newly discovered spectests issue is in WebAssembly/spec#1251.
Remove the code section in tests for malformed element section. Otherwise the code section id (0x0a) is taken as an element's table index what is a validation error. This is similar to the previously reported issue: WebAssembly#1170.
chfast
force-pushed
the
correct_malformed_elems_tests
branch
from
760cdc4 to
b08bc2c
Compare
Contributor
Author
|
Can this be merged too? |
axic
pushed a commit
to wasmx/fizzy
that referenced
this pull request
Nov 6, 2020
The upstream fix for newly discovered spectests issue is in WebAssembly/spec#1251.
chfast
added a commit
to wasmx/wasm-spec
that referenced
this pull request
Nov 10, 2020
Remove the code section in tests for malformed element section. Otherwise the code section id (0x0a) is taken as an element's table index what is a validation error. This is similar to the previously reported issue: WebAssembly#1170.
ngzhian
added a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
* [spec] automate instruction index rebuild (WebAssembly#1259) * [test] Add test for malformed functype (WebAssembly#1254) * [test] Correct tests for missing elements (WebAssembly#1251) Remove the code section in tests for malformed element section. Otherwise the code section id (0x0a) is taken as an element's table index what is a validation error. This is similar to the previously reported issue: WebAssembly#1170. * [test] Add tests for data segment with memidx 1 (WebAssembly#1249) * [test] Correct i32.store alignment in a LEB128 test (WebAssembly#1261) In the binary-leb128.wast, change the alignment of an i32.store instruction from 3 (invalid) to 2 (the intention suggested by the comment). Co-authored-by: Andreas Rossberg <rossberg@dfinity.org> Co-authored-by: Paweł Bylica <chfast@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the code section in tests for malformed element section. Otherwise the code section id (0x0a) is taken as an element's table index what is a validation error.
This is similar to the previously reported issue: #1170.