Skip to content

Do streaming lexing #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 8, 2015
Merged

Do streaming lexing #197

merged 3 commits into from
Dec 8, 2015

Conversation

rossberg
Copy link
Member

Parse from an input stream instead of a string. Two benefits:

  1. Can now parse large files (should fix String.create error in interpreter #156, although I have no 32 bit system around to test).
  2. When invoked as a REPL, the interpreter now accepts input stretching multiple lines, and recognises automatically when a command is complete.

@hhugo
Copy link

hhugo commented Nov 27, 2015

using opam, you can install a 32bit compiler on a 64bit host with
opam switch 4.02.3+32bit

@rossberg
Copy link
Member Author

rossberg commented Dec 7, 2015

Ping. Anybody wants to LGTM this?

@kg
Copy link
Contributor

kg commented Dec 7, 2015

LGTM*

  • I don't know ocaml very well but I trust your judgement, it passes tests and it looks OK

rossberg added a commit that referenced this pull request Dec 8, 2015
@rossberg
Merge pull request #197 from WebAssembly/lexstream
9911fe2 
Do streaming lexing
@rossberg rossberg merged commit 9911fe2 into master Dec 8, 2015
@rossberg rossberg deleted the lexstream branch December 8, 2015 12:37
@rossberg rossberg mentioned this pull request Dec 8, 2015
Closed
ngzhian pushed a commit to ngzhian/spec that referenced this pull request Nov 4, 2021
@Honry
[test] Add spec tests for integer abs ops (WebAssembly#197)
7fe545c 
Tests are pulled from WAVM/WAVM#260
dhil pushed a commit to dhil/webassembly-spec that referenced this pull request Mar 2, 2023
@aheejin
Update explainer on stack trace support in JS API (WebAssembly#197)
d6f5074 
This updates the explainer on
- We add stack trace option to `Exception` class in the JS API
- `Exception` can contain an optional `externref` to carry a stack trace
- `Exception` is not a subclass of JS `Error`

The WebIDL syntax is suggested by @eqrion in
WebAssembly/exception-handling#183 (comment)
and
WebAssembly/exception-handling#183 (comment).

Addresses WebAssembly#183 and WebAssembly#189.
dhil pushed a commit to dhil/webassembly-spec that referenced this pull request Oct 3, 2023
@rossberg
[interpreter] Implement types (WebAssembly#197)
fdb9f0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

String.create error in interpreter

3 participants

@rossberg @hhugo @kg