Skip to content

Fix folding for *.load_splat and table.fill #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2020
Merged

Fix folding for *.load_splat and table.fill #1486

merged 1 commit into from
Jul 16, 2020

Conversation

@binji
Copy link
Member

@binji binji commented Jul 16, 2020

Also remove default case from ir-util.cc so we get compile warnings in
the future.

@binji
Fix folding for *.load_splat and table.fill
64bcfb9 
Also remove default case from `ir-util.cc` so we get compile warnings in
the future.
@binji binji requested a review from ngzhian July 16, 2020 01:08
@binji binji mentioned this pull request Jul 16, 2020
Closed
@ngzhian
Copy link
Member

ngzhian commented Jul 16, 2020

Very nice 👍

@binji binji merged commit 04e8596 into master Jul 16, 2020
@binji binji deleted the fold-fixes branch July 16, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ngzhian ngzhian ngzhian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@binji @ngzhian