Fix #1226: IIRFilter.getFrequency inconsistent with BiquadFilter #1231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`IIRFilter.getFrequency` should return NaN for invalid frequencies just like `BiquadFilter.getFrequency` does. Basically just copied the text from biquad to iirfilter. Also took this opportunity to mark the computation as being synchronous just like BiquadFilter.
joeberkovitz
suggested changes
Jun 6, 2017
index.html
Outdated
| <p> | ||
| Given the current filter parameter settings, calculates the | ||
| frequency response for the specified frequencies. | ||
| <span class="syncrhonous">Given the current filter parameter |
There was a problem hiding this comment.
typo on <span class="syncrhonous">
joeberkovitz
approved these changes
Jun 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IIRFilter.getFrequencyshould return NaN for invalid frequenciesjust like
BiquadFilter.getFrequencydoes.Basically just copied the text from biquad to iirfilter.
Also took this opportunity to mark the computation as being
synchronous just like BiquadFilter.