Consider interrupted case on error handling section #2633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoch
added
the
Agenda+
padenot
approved these changes
May 13, 2025
mjwilson-google
removed
the
Agenda+
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 16, 2025
This is a follow-up to https://crrev.com/c/6441740 Now that the spec change has been merged: WebAudio/web-audio-api#2633 we should do the same thing as the running state when a render error occurs. Change-Id: I818de64edcd21b6a771befe57eba884a429a67fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6555082 Reviewed-by: Gabriel Brito <gabrielbrito@microsoft.com> Commit-Queue: Michael Wilson <mjwilson@chromium.org> Cr-Commit-Position: refs/heads/main@{#1461159}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines what should be done if an error occurs while an AudioContext is
interrupted.Preview | Diff