Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generic fix for
App::autoRegisterHelper()to handle classes whose constructors cannot accept the provided arguments, such as attribute-based services using#[RestController].Motivation
registerServices()passes[$this](a manager instance) as constructor arguments. Attribute-based services have__construct(string $name = ''), causing aTypeErrorthat was silently swallowed bycatch (Error $ex) {}. Services were skipped without any warning, resulting in "Service not supported" errors at runtime. Fixes #313.Changes
autoRegisterHelper()to check constructor parameter compatibility before callingnewInstanceArgs()newInstance()canAcceptArgs()— uses reflection to verify argument/parameter type compatibility (handles builtin types, class types, union types, nullable)argMatchesType()— checks a single argument against aReflectionNamedTypeApp/Apis/AttributedTest/andApp/Apis/AttributedTest2/AutoRegisterTestwith 3 test casesHow to Test / Verify
Unit tests:
composer test -- --filter AutoRegisterTesttestAutoRegisterAttributedService— verifies attribute-based services are discovered and registeredtestAutoRegisterAttributedServiceWithIncompatibleConstructorArgs— reproduces the exact bug (manager object passed as constructor arg)testAutoRegisterConstructorBasedServiceWithSuffix— verifies existing constructor-based registration still worksBreaking Changes and Migration Steps
None. The fix is backward-compatible — constructor-based services continue to work as before. The only behavioral change is that classes with incompatible constructor args are now instantiated with no args instead of being silently skipped.
Checklist
Related issues
Closes #313