Some more tslint rules #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale from the rule's page:
AMD-style require([]) and CommonJS-style require("") statements are
environment-specific and more difficult to statically analyze.
ES2015-style imports are part of the JavaScript language specfication
and recommended as the path going forward. TypeScript will compile them
to environment-specific forms as needed.
This is not a big deal, but I think it makes the code a bit nicer.
The project seems to use tabs, so we can enable the tslint rule for it.
Not really necessary, but it's nice if code is consistently formatted.
I'm not sure what is your preference here, but I've seen both styles:
} else {
and
{
else {
I think it would be nice to have a consistent style, and the former is
more common.
Owner
|
hm ok cool, didn't think there were so many missing semicolons. Definitely good to have it all consistent now though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I enabled a few more rules. They were mostly fixed tslint's
--fix.Some of them are about formatting. I don't mind what the formatting rules are, but I think it helps if they are enforced by the linter, so you don't loose time later arguing/commenting about spaces/semicolons/etc.