Reduce Kotlin-compose-wasm iteration count #225
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kotlin-compose-wasm is the longest running test in JS3 by a pretty wide margin. However after the first few iterations almost all code is in the most optimizing compiler in the respective engines. This change reduces the iterations to 5 and sets adjusts the worst case count accordingly.
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
CC @eqrion |
danleh
approved these changes
Oct 24, 2025
| "./simple/doxbee-promise.js", | ||
| ], | ||
| tags: ["default", "js", "promise", "Simple"], | ||
| iterations: 80, |
There was a problem hiding this comment.
Are the doxbee changes intended (or accidental)?
There was a problem hiding this comment.
Whoops, accidental, will revert.
That would make it still quite long (~4 sec) on my M2 MBP (probably a lot worse on phones/older CPUs). Let me run a variance analysis on the worst case count for this benchmark and get back to you. It seems somewhat unlikely it's dramatically worse than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kotlin-compose-wasm is the longest running test in JS3 by a pretty wide margin. However after the first few iterations almost all code is in the most optimizing compiler in the respective engines.
This change reduces the iterations to 5 and sets adjusts the worst case count accordingly.