Skip to content

Conversation

jernoble
Copy link
Contributor

@jernoble jernoble commented Mar 4, 2023

acd6fdd

[Cocoa|iPad] No video on Netflix.com
https://bugs.webkit.org/show_bug.cgi?id=253367
rdar://106180027

Reviewed by Jean-Yves Avenard.

In -[WebAVPlayerLayer layoutSublayers], if the videoSublayer's frame is empty, we skip ahead
and call -resolveBounds to set the initial frame dimensions. However, if we haven't yet set
the _targetVideoFrame ivar, then the empty videoSublayer frame and the empty _targetVideoFrame
will match and we'll bail out early without doing anything.

* Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm:
(-[WebAVPlayerLayer layoutSublayers]):

Canonical link: https://commits.webkit.org/261218@main

9166ac5

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2
✅ 🧪 webkitperl 🧪 ios-wk2 🧪 api-mac ✅ 🛠 gtk
🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv 🧪 mac-wk2 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@jernoble jernoble self-assigned this Mar 4, 2023
@jernoble jernoble added the Media Bugs related to the HTML 5 Media elements. label Mar 4, 2023
@jernoble jernoble added the merge-queue Applied to send a pull request to merge-queue label Mar 4, 2023
https://bugs.webkit.org/show_bug.cgi?id=253367
rdar://106180027

Reviewed by Jean-Yves Avenard.

In -[WebAVPlayerLayer layoutSublayers], if the videoSublayer's frame is empty, we skip ahead
and call -resolveBounds to set the initial frame dimensions. However, if we haven't yet set
the _targetVideoFrame ivar, then the empty videoSublayer frame and the empty _targetVideoFrame
will match and we'll bail out early without doing anything.

* Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm:
(-[WebAVPlayerLayer layoutSublayers]):

Canonical link: https://commits.webkit.org/261218@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/CocoaiPad-No-video-on-Netflix-com branch from 9166ac5 to acd6fdd Compare March 4, 2023 09:57
@webkit-commit-queue
Copy link
Collaborator

Committed 261218@main (acd6fdd): https://commits.webkit.org/261218@main

Reviewed commits have been landed. Closing PR #11050 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit acd6fdd into WebKit:main Mar 4, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Media Bugs related to the HTML 5 Media elements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants