Skip to content

Remove support for TagName::command #12173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2023
Merged

Remove support for TagName::command #12173

merged 1 commit into from
Mar 31, 2023

Conversation

@annevk
Copy link
Contributor

@annevk annevk commented Mar 30, 2023 •
edited by webkit-early-warning-system
Loading

5b2c72f

Remove support for TagName::command
https://bugs.webkit.org/show_bug.cgi?id=254737
rdar://107416609

Reviewed by Ryosuke Niwa.

After this change the X in

  <command>X

will be a child rather than a following sibling of the (unknown) command element, as HTML requires as of about a decade ago.

* LayoutTests/html5lib/generated/run-tests25-data-expected.txt:
* LayoutTests/html5lib/generated/run-tests25-write-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests25_run_type=uri-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests25_run_type=write-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests25_run_type=write_single-expected.txt:
* Source/WebCore/WebCore.order:
* Source/WebCore/WebCoreMacros.cmake:

Correct a typo in the file name for MathML attributes and merge MAIN_DEPENDENCY into DEPENDS for GENERATE_DOM_NAME_ENUM in the hopes of making WebKitGTK and WinCairo build correctly.

* Source/WebCore/html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parametersForPlugin):
(WebCore::HTMLObjectElement::renderFallbackContent):
(WebCore::preventsParentObjectFromExposure):
(WebCore::HTMLObjectElement::containsJavaApplet const):
* Source/WebCore/html/HTMLTagNames.in:
* Source/WebCore/html/parser/HTMLStackItem.h:
(WebCore::isSpecialNode):
* Source/WebCore/html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):

Canonical link: https://commits.webkit.org/262431@main

828672e

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
❌ 🛠 🧪 merge ✅ 🛠 watch-sim

@annevk annevk self-assigned this Mar 30, 2023
@annevk annevk added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Mar 30, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 30, 2023 •
edited
Loading

EWS run on previous version of this PR (hash e8ca064)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
  🧪 api-ios   🧪 mac-wk1 ⏳ 🧪 gtk-wk2
✅ 🛠 tv   🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 tv-sim ⏳ 🧪 mac-AS-debug-wk2
✅ 🛠 watch   🧪 mac-wk2-stress
✅ 🛠 watch-sim

@annevk annevk marked this pull request as ready for review March 30, 2023 13:19
@annevk annevk requested review from cdumez and rniwa as code owners March 30, 2023 13:19
@annevk annevk force-pushed the eng/Remove-support-for-TagNamecommand branch from e8ca064 to 89ad25f Compare March 30, 2023 13:20
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 30, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 89ad25f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 api-ios   🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 tv   🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ⏳ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@annevk annevk force-pushed the eng/Remove-support-for-TagNamecommand branch from 89ad25f to e8c9653 Compare March 30, 2023 13:45
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 30, 2023 •
edited
Loading

EWS run on previous version of this PR (hash e8c9653)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe ❌ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🛠 gtk
✅ 🧪 api-ios   🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🛠 tv   🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 30, 2023
@annevk annevk removed the merging-blocked Applied to prevent a change from being merged label Mar 30, 2023
@annevk annevk force-pushed the eng/Remove-support-for-TagNamecommand branch from e8c9653 to 296a00e Compare March 30, 2023 14:45
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 30, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 296a00e)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe ❌ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🛠 gtk
✅ 🧪 api-ios ❌ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🛠 tv ❌ 🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv-sim ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 30, 2023
@annevk annevk removed the merging-blocked Applied to prevent a change from being merged label Mar 31, 2023
@annevk annevk force-pushed the eng/Remove-support-for-TagNamecommand branch from 296a00e to 99bd17d Compare March 31, 2023 07:30
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 31, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 99bd17d)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe ⏳ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2   🧪 api-mac ❌ 🛠 gtk
⏳ 🧪 api-ios   🧪 mac-wk1 ❌ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc ✅ 🛠 tv   🧪 mac-wk2 ❌ 🧪 api-gtk
⏳ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv-sim ⏳ 🧪 mac-AS-debug-wk2
⏳ 🛠 watch   🧪 mac-wk2-stress
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 31, 2023
@annevk annevk added skip-ews Applied to prevent a change from being run on EWS and removed skip-ews Applied to prevent a change from being run on EWS merging-blocked Applied to prevent a change from being merged labels Mar 31, 2023
@annevk annevk force-pushed the eng/Remove-support-for-TagNamecommand branch from 99bd17d to edfe48b Compare March 31, 2023 07:43
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 31, 2023 •
edited
Loading

EWS run on previous version of this PR (hash edfe48b)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe ⏳ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@annevk
Copy link
Contributor Author

annevk commented Mar 31, 2023

WebKitGTK and WinCairo likely fail due to an issue with Source/WebCore/WebCoreMacros.cmake, but I can't figure it out.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 31, 2023
@annevk annevk removed the merging-blocked Applied to prevent a change from being merged label Mar 31, 2023
@annevk annevk force-pushed the eng/Remove-support-for-TagNamecommand branch from edfe48b to 909f471 Compare March 31, 2023 10:30
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 31, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 909f471)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe ⏳ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ❌ 🛠 gtk
  🧪 api-ios   🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🛠 tv   🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch   🧪 mac-wk2-stress
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 31, 2023
@annevk annevk added skip-ews Applied to prevent a change from being run on EWS and removed merging-blocked Applied to prevent a change from being merged skip-ews Applied to prevent a change from being run on EWS labels Mar 31, 2023
@annevk annevk force-pushed the eng/Remove-support-for-TagNamecommand branch from 909f471 to 828672e Compare March 31, 2023 10:46
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 31, 2023 •
edited
Loading

EWS run on current version of this PR (hash 828672e)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
❌ 🛠 🧪 merge ✅ 🛠 watch-sim

@annevk annevk added the request-merge-queue Request a pull request to be added to merge-queue once ready label Mar 31, 2023
@Ahmad-S792 Ahmad-S792 added merge-queue Applied to send a pull request to merge-queue and removed request-merge-queue Request a pull request to be added to merge-queue once ready labels Mar 31, 2023
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Remove-support-for-TagNamecommand branch from 828672e to e400d8c Compare March 31, 2023 18:26
@annevk
Remove support for TagName::command
5b2c72f 
https://bugs.webkit.org/show_bug.cgi?id=254737
rdar://107416609

Reviewed by Ryosuke Niwa.

After this change the X in

  <command>X

will be a child rather than a following sibling of the (unknown) command element, as HTML requires as of about a decade ago.

* LayoutTests/html5lib/generated/run-tests25-data-expected.txt:
* LayoutTests/html5lib/generated/run-tests25-write-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests25_run_type=uri-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests25_run_type=write-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests25_run_type=write_single-expected.txt:
* Source/WebCore/WebCore.order:
* Source/WebCore/WebCoreMacros.cmake:

Correct a typo in the file name for MathML attributes and merge MAIN_DEPENDENCY into DEPENDS for GENERATE_DOM_NAME_ENUM in the hopes of making WebKitGTK and WinCairo build correctly.

* Source/WebCore/html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parametersForPlugin):
(WebCore::HTMLObjectElement::renderFallbackContent):
(WebCore::preventsParentObjectFromExposure):
(WebCore::HTMLObjectElement::containsJavaApplet const):
* Source/WebCore/html/HTMLTagNames.in:
* Source/WebCore/html/parser/HTMLStackItem.h:
(WebCore::isSpecialNode):
* Source/WebCore/html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):

Canonical link: https://commits.webkit.org/262431@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Remove-support-for-TagNamecommand branch from e400d8c to 5b2c72f Compare March 31, 2023 18:29
@webkit-commit-queue
Copy link
Collaborator

Committed 262431@main (5b2c72f): https://commits.webkit.org/262431@main

Reviewed commits have been landed. Closing PR #12173 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 5b2c72f into WebKit:main Mar 31, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 31, 2023
@annevk annevk deleted the eng/Remove-support-for-TagNamecommand branch April 1, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rniwa rniwa rniwa approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@annevk annevk

Labels

DOM For bugs specific to XML/HTML DOM elements (including parsing).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@annevk @webkit-early-warning-system @webkit-commit-queue @rniwa @Ahmad-S792 @webkit-ews-buildbot