Skip to content

InViewSizeAdjust LayoutPhase should have ScriptDisallowedScope #13486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2023
Merged

InViewSizeAdjust LayoutPhase should have ScriptDisallowedScope #13486

merged 1 commit into from
May 9, 2023

Conversation

@rniwa
Copy link
Member

@rniwa rniwa commented May 5, 2023 •
edited by webkit-early-warning-system
Loading

ecfaca4

InViewSizeAdjust LayoutPhase should have ScriptDisallowedScope
https://bugs.webkit.org/show_bug.cgi?id=256354

Reviewed by Simon Fraser.

Deployed ScriptDisallowedScope::InMainThread in LayoutPhase::InViewSizeAdjust.

* Source/WebCore/page/LocalFrameViewLayoutContext.cpp:
(WebCore::LocalFrameViewLayoutContext::performLayout):

Canonical link: https://commits.webkit.org/263843@main

5b9958b

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@rniwa rniwa requested a review from cdumez as a code owner May 5, 2023 06:15
@rniwa rniwa self-assigned this May 5, 2023
@rniwa rniwa added the Layout and Rendering For bugs with layout and rendering of Web pages. label May 5, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 5, 2023 •
edited
Loading

EWS run on previous version of this PR (hash ca889c0)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 5, 2023
@rniwa rniwa removed the merging-blocked Applied to prevent a change from being merged label May 8, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 8, 2023 •
edited
Loading

EWS run on current version of this PR (hash 5b9958b)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@rniwa rniwa requested review from alanbaradlay, anttijk and smfr May 9, 2023 00:53
@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 9, 2023
@rniwa
InViewSizeAdjust LayoutPhase should have ScriptDisallowedScope
ecfaca4 
https://bugs.webkit.org/show_bug.cgi?id=256354

Reviewed by Simon Fraser.

Deployed ScriptDisallowedScope::InMainThread in LayoutPhase::InViewSizeAdjust.

* Source/WebCore/page/LocalFrameViewLayoutContext.cpp:
(WebCore::LocalFrameViewLayoutContext::performLayout):

Canonical link: https://commits.webkit.org/263843@main
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented May 9, 2023

Committed 263843@main (ecfaca4): https://commits.webkit.org/263843@main

Reviewed commits have been landed. Closing PR #13486 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ecfaca4 into WebKit:main May 9, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 9, 2023
@rniwa rniwa deleted the fix256354 branch May 9, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smfr smfr smfr approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@anttijk anttijk Awaiting requested review from anttijk

@alanbaradlay alanbaradlay Awaiting requested review from alanbaradlay

Assignees

@rniwa rniwa

Labels

Layout and Rendering For bugs with layout and rendering of Web pages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rniwa @webkit-early-warning-system @webkit-commit-queue @smfr @webkit-ews-buildbot