Skip to content

Conversation

Ahmad-S792
Copy link
Contributor

@Ahmad-S792 Ahmad-S792 commented May 9, 2023

form.elements should not contain image elements
https://bugs.webkit.org/show_bug.cgi?id=87834

Reviewed by NOBODY (OOPS!).

This patch aligns WebKit with Web-Spec [1], Blink / Chromium and Gecko / Firefox.

Image elements should not appear in the form.elements as image element is not
mentioned in listed elements of specs.

[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#category-listed

Cherry-pick test: https://chromium.googlesource.com/chromium/src.git/+/5ab9146e05f7e315976e7066b29738dbd6d56f9e

* Source/WebCore/html/HTMLFormControlsCollection.cpp:
(HTMLFormControlsCollection::updateNamedElementCache): Remove 'imageElements' stuff
* LayoutTests/fast/dom/htmlformcontrolscollection-no-img.html: Add Test Case
* LayoutTests/fast/dom/htmlformcontrolscollection-no-img-expected.txt: Add Test Case Expectation
* LayoutTests/fast/forms/form-image-access-by-name-expected.txt: Rebaselined
* LayoutTests/fast/forms/form-image-access-by-name.html: Rebaselined

0a8ca6d

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 🧪 gtk-wk2
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ❌ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@Ahmad-S792 Ahmad-S792 added the Forms For bugs specific to form elements (checkboxes, buttons, text fields, etc.) label May 9, 2023
@Ahmad-S792 Ahmad-S792 self-assigned this May 9, 2023
@Ahmad-S792 Ahmad-S792 force-pushed the fix87834-form-collection branch from 9ed1ad9 to b3e0386 Compare May 9, 2023 00:25
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 9, 2023
https://bugs.webkit.org/show_bug.cgi?id=87834

Reviewed by NOBODY (OOPS!).

This patch aligns WebKit with Web-Spec [1], Blink / Chromium and Gecko / Firefox.

Image elements should not appear in the form.elements as image element is not
mentioned in listed elements of specs.

[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#category-listed

Cherry-pick test: https://chromium.googlesource.com/chromium/src.git/+/5ab9146e05f7e315976e7066b29738dbd6d56f9e

* Source/WebCore/html/HTMLFormControlsCollection.cpp:
(HTMLFormControlsCollection::updateNamedElementCache): Remove 'imageElements' stuff
* LayoutTests/fast/dom/htmlformcontrolscollection-no-img.html: Add Test Case
* LayoutTests/fast/dom/htmlformcontrolscollection-no-img-expected.txt: Add Test Case Expectation
* LayoutTests/fast/forms/form-image-access-by-name-expected.txt: Rebaselined
* LayoutTests/fast/forms/form-image-access-by-name.html: Rebaselined
@Ahmad-S792 Ahmad-S792 force-pushed the fix87834-form-collection branch from b3e0386 to 0a8ca6d Compare May 9, 2023 20:17
@Ahmad-S792 Ahmad-S792 removed the merging-blocked Applied to prevent a change from being merged label May 9, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 9, 2023
@Ahmad-S792 Ahmad-S792 closed this May 9, 2023
@Ahmad-S792 Ahmad-S792 deleted the fix87834-form-collection branch September 2, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Forms For bugs specific to form elements (checkboxes, buttons, text fields, etc.) merging-blocked Applied to prevent a change from being merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants