Web Inspector: REGRESSION(?): Console: find results count has no left padding #13645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash a318f59)
|
patrickangle
approved these changes
May 17, 2023
Comment on lines
79
to
74
There was a problem hiding this comment.
I think we can use the logical border radius properties here. e.g. border-start-start-radius (https://developer.mozilla.org/en-US/docs/Web/CSS/border-start-start-radius)
There was a problem hiding this comment.
actually turns out we don't really need these anymore cause of --find-banner-search-box-border-radius-start
|
EWS run on current version of this PR (hash f061091)
|
… padding https://bugs.webkit.org/show_bug.cgi?id=256531 Reviewed by Patrick Angle. * Source/WebInspectorUI/UserInterface/Views/FindBanner.css: (.find-banner): (.find-banner > input[type="search"]): (.find-banner > button): (.find-banner > button.segmented): (.find-banner > label): (.find-banner > label:not(:empty)): Added. (.find-banner > :first-child): Deleted. (.find-banner > :last-child): Deleted. (.find-banner.console-find-banner): Deleted. (body .find-banner.console-find-banner): Deleted. (.find-banner.console-find-banner > input[type="search"]): Deleted. (body[dir=ltr] .find-banner.console-find-banner > input[type="search"]): Deleted. (body[dir=rtl] .find-banner.console-find-banner > input[type="search"]): Deleted. (.find-banner.console-find-banner > :is(input[type="search"], button)): Deleted. (.find-banner.console-find-banner > input[type="search"]::-webkit-textfield-decoration-container): Deleted. (.find-banner.console-find-banner > input[type="search"]:focus, .find-banner.console-find-banner > input[type="search"]:focus ~ button, .find-banner.console-find-banner > input[type="search"]:not(:placeholder-shown), .find-banner.console-find-banner > input[type="search"]:not(:placeholder-shown) ~ button): Deleted. * Source/WebInspectorUI/UserInterface/Views/LogContentView.css: (.navigation-bar > .item.find-banner.console): Added. (:not(.console-drawer) > .navigation-bar > .item.find-banner.console): Added. (.navigation-bar > .item.find-banner.console > input[type="search"]): Added. (.navigation-bar > .item.find-banner.console > :is(input[type="search"], button)): Added. (.navigation-bar > .item.find-banner.console > input[type="search"]::-webkit-textfield-decoration-container): Added. (.navigation-bar > .item.find-banner.console > input[type="search"]:focus, .navigation-bar > .item.find-banner.console > input[type="search"]:focus ~ button, .navigation-bar > .item.find-banner.console > input[type="search"]:not(:placeholder-shown), .navigation-bar > .item.find-banner.console > input[type="search"]:not(:placeholder-shown) ~ button ): Added. (.console-find-banner): Deleted. Avoid using `:first-child`/`:last-child` (and `!important`) as they have very little control over what kinds of situations they apply (e.g. we don't want to add padding to `label:empty`). Don't add any outside `margin` as that's handled by the containing `WI.NavigationBar` (or adjacent `WI.NavigationItem`) unless we know for sure that it's the first/last `WI.NavigationItem` in the `WI.NavigationBar`. Drive-by: Move styles to a more relevant location. * Source/WebInspectorUI/UserInterface/Views/FindBanner.js: (WI.FindBanner): * Source/WebInspectorUI/UserInterface/Views/LogContentView.js: (WI.LogContentView): Drive-by: Rework optional parameters into `{...} = {}` to match existing pattern elsewhere. Canonical link: https://commits.webkit.org/264167@main
webkit-commit-queue
force-pushed
the
eng/256531
branch
from
f061091 to
347111d
Compare
|
Committed 264167@main (347111d): https://commits.webkit.org/264167@main Reviewed commits have been landed. Closing PR #13645 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
347111d
f061091
🛠 wincairo🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🧪 ios-wk2-wpt🧪 api-ios🧪 mac-AS-debug-wk2