Skip to content

REGRESSION(264582@main): [GTK] UI process crash: Assertion 'this->_M_is_engaged()' failed. #14674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2023
Merged

REGRESSION(264582@main): [GTK] UI process crash: Assertion 'this->_M_is_engaged()' failed. #14674

merged 1 commit into from
Jun 6, 2023

Conversation

@mcatanzaro
Copy link
Contributor

@mcatanzaro mcatanzaro commented Jun 5, 2023 •
edited by webkit-early-warning-system
Loading

d501d8d

REGRESSION(264582@main): [GTK] UI process crash: Assertion 'this->_M_is_engaged()' failed.
https://bugs.webkit.org/show_bug.cgi?id=257690

Reviewed by Carlos Garcia Campos.

I incorrectly assumed that there would always be at least one pointer
motion event before a pointer leave event. This is not correct; e.g. it
happens when Epiphany restores a previous browser session. Instead of
crashing when libstdc++ assertions are enabled, let's just bail. There
is probably no need to synthesize a fake motion event for WebCore.

* Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseLeave):

Canonical link: https://commits.webkit.org/264895@main

9ef0c35

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
❌ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mcatanzaro mcatanzaro requested a review from a team as a code owner June 5, 2023 17:20
@mcatanzaro mcatanzaro self-assigned this Jun 5, 2023
@mcatanzaro mcatanzaro added the WebKitGTK Bugs related to the Gtk API layer. label Jun 5, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 5, 2023 •
edited
Loading

EWS run on current version of this PR (hash 9ef0c35)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
❌ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 5, 2023
@mcatanzaro mcatanzaro removed the merging-blocked Applied to prevent a change from being merged label Jun 5, 2023
@mcatanzaro mcatanzaro added the merge-queue Applied to send a pull request to merge-queue label Jun 6, 2023
@mcatanzaro
REGRESSION(264582@main): [GTK] UI process crash: Assertion 'this->_M_…
d501d8d 
…is_engaged()' failed.

https://bugs.webkit.org/show_bug.cgi?id=257690

Reviewed by Carlos Garcia Campos.

I incorrectly assumed that there would always be at least one pointer
motion event before a pointer leave event. This is not correct; e.g. it
happens when Epiphany restores a previous browser session. Instead of
crashing when libstdc++ assertions are enabled, let's just bail. There
is probably no need to synthesize a fake motion event for WebCore.

* Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseLeave):

Canonical link: https://commits.webkit.org/264895@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/REGRESSION264582main-GTK-UI-process-crash-Assertion-this-_M_is_engaged-failed- branch from 9ef0c35 to d501d8d Compare June 6, 2023 13:36
@webkit-commit-queue
Copy link
Collaborator

Committed 264895@main (d501d8d): https://commits.webkit.org/264895@main

Reviewed commits have been landed. Closing PR #14674 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit d501d8d into WebKit:main Jun 6, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosgcampos carlosgcampos carlosgcampos approved these changes

Assignees

@mcatanzaro mcatanzaro

Labels

WebKitGTK Bugs related to the Gtk API layer.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mcatanzaro @webkit-early-warning-system @webkit-commit-queue @carlosgcampos @webkit-ews-buildbot